Port review of pure-ftpd

Scott Haneda talklists at newgeo.com
Tue Oct 27 19:58:40 PDT 2009


>> repeat with aVariant in variantList
>> 	if aVariant starts with lang_ then counter++
>> 	if counter > 1 then abort with message
>> end repeat
>>
>> That seems short and to the point to me.
>
> It would work. This would basically be reimplementing the conflicts  
> mechanism yourself, but hiding that fact in the output of "port  
> variants". I'm not sure I agree with reimplementing existing  
> MacPorts features in individual portfiles, but I will grant that the  
> conflicts output from "port variants" is very ugly when there are  
> many variants with many conflicts. Perhaps there is a way "port  
> variants" could display this information in a more succinct and less  
> cluttered way; that would solve the problem not just for you but all  
> other ports that have many conflicting variants. (See "port variants  
> minivmac".)


I guess I am just going to leave it.  The chances that someone  
installs more than one language are slim.  If I use my method above, I  
have to maintain a list of language names, iterate them, and do other  
magic on them.

In addition, I am braking a convention.

I do not really understand the conflicting variants issue, and seem to  
be unable to find a lot of documentation on the matter.  In this case,  
I know I can not append more than one language to the configure.args,  
and wanted to solve that.  I suppose I am ok with this though.

If someone has a nice and clean way to do it, I am all ears, but the  
previous example posted here, I have looked at it a few times, and to  
be honest, that seems like a lot of stuff to put in a port file just  
to have languages not collide.

Thanks for all the advice on this one, I am going to submit it tonight  
I think.
-- 
Scott * If you contact me off list replace talklists@ with scott@ *



More information about the macports-dev mailing list