[66441] trunk/dports/editors

[Ryan Schmidt]

On Apr 13, 2010, at 10:39, singingwolfboy at macports.org wrote:

> Revision: 66441
>          http://trac.macports.org/changeset/66441
> Author:   singingwolfboy at macports.org
> Date:     2010-04-13 08:39:15 -0700 (Tue, 13 Apr 2010)
> Log Message:
> -----------
> Added port for NERD Tree Vim plugin

> +fetch {
> +    xinstall -d ${prefix}/var/macports/distfiles/${name}/
> +    set dl ${prefix}/var/macports/distfiles/${name}/${distname}${extract.suffix}
> +    foreach site ${master_sites} {
> +        if {[file exists $dl]} {
> +            if {[file size $dl] == 0} {
> +                system "curl ${site} > ${dl}"
> +            }
> +        } else {
> +            system "curl ${site} > ${dl}"
> +        }
> +    }
> +}

Why override the fetch phase?


> +    # rebuild help tags
> +    system "${prefix}/bin/vim -c \":helptags /opt/local/share/vim/vim72/doc\" -c \":q\" "

You should use ${prefix}, not hardcode /opt/local. Also it appears that here inside the destroot phase, you're doing operations outside of the destroot directory.