[60769] trunk/base/src

[Rainer Müller]

On 2009-11-23 04:23 , jmr at macports.org wrote:
> Revision: 60769
>           http://trac.macports.org/changeset/60769
> Author:   jmr at macports.org
> Date:     2009-11-22 19:23:47 -0800 (Sun, 22 Nov 2009)
> Log Message:
> -----------
> stop including command output in the return value of the system proc (#21084), print log file location and ticket guidelines URL when a target fails
> 
> Modified Paths:
> --------------
>     trunk/base/src/macports1.0/macports.tcl
>     trunk/base/src/pextlib1.0/system.c
>     trunk/base/src/port/port.tcl
> 
[...]
> Modified: trunk/base/src/port/port.tcl
> ===================================================================
> --- trunk/base/src/port/port.tcl	2009-11-23 00:54:11 UTC (rev 60768)
> +++ trunk/base/src/port/port.tcl	2009-11-23 03:23:47 UTC (rev 60769)
> @@ -155,6 +155,13 @@
>      }
>  }
>  
> +# show the URL for the ticket reporting instructions
> +proc print_tickets_url {args} {
> +    if {![macports::ui_isset ports_quiet]} {
> +        ui_msg "To report a bug, see <http://guide.macports.org/#project.tickets>"
> +    }
> +}
> +

This error message is now also displayed on wrong user input, for
example a wrong port name.

For example:
  $ port -v upgrade does_not_exist
  Error: does_not_exist is not installed
  To report a bug, see <http://guide.macports.org/#project.tickets>

This message should only be displayed if an error occurs during
processing. I am not sure if there is a quick way to fix this as the
return code of actions does currently not tell the reason for the
failure in every case.

If nobody else has a quick solution, I will open a remainder ticket in
the 1.9 milestone as this needs to be resolved before the release.

Rainer