Warning: Line X seems to hardcode the version number, consider using ${version} instead

[nox]

On a side note, we should really have a procedure which escapes characters bearing special meaning in regard to regular expressions.

Le 6 janv. 2010 à 17:59, Ryan Schmidt a écrit :

> On Jan 6, 2010, at 10:06, nox wrote:
> 
>> Is there anyone strongly against the idea of moving this warning to the nitpicking ones? Every lint report I've received with this warning so far has been a false positive (e.g. docbook-xml-5.0).
> 
> I don't know. I do agree it could stand to be refined somewhat. In the case of docbook-xml-5.0, it complains that the version (5.0) is part of the "name" line; we could grant an exclusion for that line. And in the case of graphviz-oldgui, the version is an integer (16) which appears in several unrelated places in the portfile (as part of a checksum, and of "rmd160", and of "UTF-16"); here I was thinking of skipping the check unless version isn't an integer.
> 
> I don't think it needs to be our goal that every port passes every lint test; some of the things it says are just suggestions. But I agree it's annoying to repeatedly receive the same lint reports by email for things one has decided not to fix.
> 
>