Peer review request: changes to portutil.tcl

Ryan Schmidt ryandesign at
Thu Jan 28 07:24:40 PST 2010

Could I get another pair of eyes to review my proposed changes?

I'm changing a fundamental function in MacPorts base, with the intended result that arguments should retain any quoting. It seems to work for me for the case I'm interested in at the moment, but I haven't tested all other cases, and I'm confused why the code was written the way it was before, and why this problem hasn't come up before.

Landon, I'm Cc'ing you specifically because my proposed change seems to undo r628 which you committed 7 years ago; if you can recall the reasoning behind your commit that might help evaluate this proposed change.

More information about the macports-dev mailing list