[70103] trunk/dports/lang/parrot/Portfile

[Ryan Schmidt]

On Jul 29, 2010, at 19:45, tommyd at macports.org wrote:

> Revision: 70103
>          http://trac.macports.org/changeset/70103
> Author:   tommyd at macports.org
> Date:     2010-07-29 17:45:30 -0700 (Thu, 29 Jul 2010)
> Log Message:
> -----------
> * configure with the correct --mandir so dependent ports
>  which pick up the mandir through parrot_config install
>  their man pages in a proper location
> * install parrot straight into ${prefix}, so documentation,
>  man pages (again) and other files are in the expected
>  locations

> @@ -26,10 +27,12 @@
> depends_lib             port:gmp port:icu
> 
> configure.cmd           perl Configure.pl
> -configure.pre_args      --prefix=${prefix}/lib/parrot
> -configure.args          --optimize
> +configure.pre_args      --prefix=${prefix} \
> +                        --mandir=${prefix}/share/man \
> +                        --optimize

The convention is that configure.pre_args is only for setting the prefix. Everything else goes in configure.args. So it would be better to say:

configure.pre_args      --prefix=${prefix}
configure.args          --mandir=${prefix}/share/man \
                        --optimize

Except that --prefix=${prefix} is the default for configure.pre_args, so you can simplify to just:

configure.args          --mandir=${prefix}/share/man \
                        --optimize


Were your changes approved by the port's maintainers, by the way?