select group bug?

Rainer Müller raimue at macports.org
Wed Jun 30 09:46:11 PDT 2010


On 2010-06-30 17:02 , Michael Dickens wrote:
> In the file dports/_resources/port1.0/group/select-1.0.tcl:54-60
> 
> {{{
> post-destroot {
>     if {${select.file} != "" || ${select.group} != ""} {
>         select::install ${select.group} ${select.file}
>     } else {
>         ui_debug "PortGroup select: select.group or select.file not set"
>     }
> }
> }}}
> 
> Q: Shouldn't the "||" be "&&" instead?  I think one never wants to
> install a select file unless both the filename and group are specified. 
> I'm happy to make the change, just double checking that I understand the
> intent. - MLD

Yes, you are right. Please go ahead and change it.

Rainer


More information about the macports-dev mailing list