[64959] trunk/dports/devel/hs-NewBinary/Portfile

[Ryan Schmidt]

On Mar 18, 2010, at 09:25, gwright at macports.org wrote:

> Revision: 64959
>          http://trac.macports.org/changeset/64959
> Author:   gwright at macports.org
> Date:     2010-03-18 07:25:07 -0700 (Thu, 18 Mar 2010)
> Log Message:
> -----------
> Add name explicitly to fix a port lint message.
> 
> Modified Paths:
> --------------
>    trunk/dports/devel/hs-NewBinary/Portfile
> 
> Modified: trunk/dports/devel/hs-NewBinary/Portfile
> ===================================================================
> --- trunk/dports/devel/hs-NewBinary/Portfile	2010-03-18 14:22:06 UTC (rev 64958)
> +++ trunk/dports/devel/hs-NewBinary/Portfile	2010-03-18 14:25:07 UTC (rev 64959)
> @@ -4,6 +4,7 @@
> 
> PortGroup	haskell 1.0
> haskell.setup	NewBinary 0.2.1
> +name		hs-NewBinary

The lint message in question reads:

Error: Portfile directory hs-NewBinary does not match port name hs-newbinary

The haskell portgroup deliberately lowercases the supplied haskell module name:

    name                hs-[string tolower ${package}]

So why are you defeating that in the ports you've been adding? If we want lowercase portnames, as this convenience in the portgroup suggests, you should not be defeating it in your ports. OTOH if we want CamelCase portnames, then the lowercasing convenience should be removed from the portgroup.