[64778] trunk/dports/devel
Joshua Root
jmr at macports.org
Fri Mar 19 18:07:15 PDT 2010
On 2010-3-20 11:49 , Jordan K. Hubbard wrote:
>
> On Mar 19, 2010, at 3:07 AM, Ryan Schmidt wrote:
>
>> Instead of these lines, you should just clear the distfiles variable, like this:
>>
>> distfiles
>
> I don't know about you guys, but I find what is essentially a key/value pair without a value to be somewhat harder to read. "What's that line do??" would be my first reaction, even if I knew that no arguments was essentially equivalent to the NULL set being passed. Elsewhere, of course, the convention is to say "use_foo no", which certainly parses reasonably well even if the rules for when a use_foo is permissible/available are somewhat unclear. Perhaps this is a good opportunity to fix that? "use_distfiles no" would certainly be more readable, or we could introduce a new "ignore" procedure perhaps.. ("ignore distfiles").
'eval distfiles {}' maybe? Or 'fetch.type none'?
- Josh
More information about the macports-dev
mailing list