patchfiles and specifying -p

[Jeremy Huddleston]

On May 17, 2010, at 13:54, Scott Haneda wrote:

> On May 17, 2010, at 8:40 AM, Blair Zajac <blair at orcaware.com> wrote:
> 
>> I don't want to have to modify patches.  I like taking patches from Ubuntu/Debian and the upstream source and drop them into a portfile with no modifications.  I shouldn't need to regenerate a patch just to get them all to have the same -p value.  RPM spec files don't require this, Ubuntu/Debian packages don't.
>> 
>> If we don't want to have a way to specify -p, then we can do what Debian does, which is try to apply the patch with -p 0, -p 1 up to -p N until it succeeds or fails.  This would be fine with me.
> 
> Agreed. Currently I deal with two ports that have patches. I need not do anything to them other than download them from the source repo, drop them into "Files", and reference the patch in the Portfile.
> 
> That is easy. I like that I can't mess up the patch because I'm not actually doing more than just applying a patch.
> 
> I don't mind some advanced options, I don't think default behavior should change. The current method works rather well, is unambiguous, easy to debug, and follows a familiar way to patch files that most have dealt with before.

what's wrong with:

patch.args -p1