[73037] trunk/dports/sysutils/Pallet/Portfile

[Ryan Schmidt]

On Nov 1, 2010, at 16:54, juanger at macports.org wrote:

> Revision: 73037
>          http://trac.macports.org/changeset/73037
> Author:   juanger at macports.org
> Date:     2010-11-01 14:54:30 -0700 (Mon, 01 Nov 2010)
> Log Message:
> -----------
> New version of Pallet. Fixes #27084 and uses the new version of the framework.
> 
> Modified Paths:
> --------------
>    trunk/dports/sysutils/Pallet/Portfile


> xcode.target            Pallet
> xcode.configuration     Release
> 
> -xcode.build.settings       FRAMEWORK_SEARCH_PATHS="${frameworks_dir}"
> -xcode.destroot.settings    FRAMEWORK_SEARCH_PATHS="${frameworks_dir}"
> +if {"darwin" == ${os.platform}} {
> +  if {9 <= ${os.major}} {
> +    xcode.configuration     Release

This line is pointless since this value has already been set above.

> +  } else {
> +    ui_error "You need at least Mac OS X Leopard to build this port."
> +    return -code error "incompatible Mac OS X version"

You can't ui_error or return -code error here; this will be executed on EVERY command the user tries to use with this port on Tiger, including "port info" and "portindex". You must restrict such things to a phase, such as pre-fetch.

> +  }
> +}

May I suggest this much simpler approach:

platform darwin 8 {
	pre-fetch {
		ui_error "${name} requires Mac OS X 10.5 or greater."
		return -code error "incompatible Mac OS X version"
	}
}