[73849] trunk/dports/devel/icu

[Ryan Schmidt]

On Nov 27, 2010, at 02:37, takanori at macports.org wrote:

> Revision: 73849
>          http://trac.macports.org/changeset/73849
> Author:   takanori at macports.org
> Date:     2010-11-27 00:37:19 -0800 (Sat, 27 Nov 2010)
> Log Message:
> -----------
> icu:
> - Updated to the latest stable version (4.4.2). (#26044)
> - Fixed a broken static library problem. (#26435)
> - Added +with_doxygen for better API docs.

Variant names should not begin with "with_" (or "without_" or "enable_" or "disable_"). They should either begin with nothing (preferred), or "no_".


> +        if {${build_arch} != "x86_64"} {
> +            return -code error "Sorry, building universal ICU library is now supported on x86_64 Macs only."
> +        }

Why is build_arch relevant for the universal variant? Shouldn't only universal_archs matter?