[72457] trunk/dports/devel/ld64/Portfile

[Mike Alexander]

--On October 16, 2010 7:50:43 AM -0500 Ryan Schmidt 
<ryandesign at macports.org> wrote:

> On Oct 16, 2010, at 04:53, mfeiri at macports.org wrote:
>
>> Revision: 72457
>>          http://trac.macports.org/changeset/72457
>> Author:   mfeiri at macports.org
>> Date:     2010-10-16 02:52:57 -0700 (Sat, 16 Oct 2010)
>> Log Message:
>> -----------
>> move llvm-config to pre-configure
>
>
>> +    pre-configure {
>> +        build.env       OTHER_CFLAGS='[exec
>> ${prefix}/bin/llvm-config --cflags]' +        destroot.env
>> OTHER_CFLAGS='[exec ${prefix}/bin/llvm-config --cflags]' +    }
>
>> +    pre-configure {
>> +        build.env       OTHER_CFLAGS='[exec
>> ${prefix}/bin/llvm-config --cflags]' +        destroot.env
>> OTHER_CFLAGS='[exec ${prefix}/bin/llvm-config --cflags]' +    }
>
> Actually, that's not going to be optimal. build.env should be set in
> pre-build, and destroot.env should be set in pre-destroot. Otherwise
> you cause problems for someone who explicitly runs "sudo port
> configure ld64" and then wants to continue building and destrooting
> it later.

There's another problem with this.  Since this executes 
"${prefix}/bin/llvm-config" every time the port file is parsed it fails 
if whatever provides that (maybe llvm?) is not installed.  This means 
that portindex fails with this patch if you don't have something 
providing llvm-config installed.

      Mike