[72782] trunk/dports/science/root/Portfile

[Michael Dickens]

On Oct 26, 2010, at 5:34 PM, Ryan Schmidt wrote:
> On Oct 26, 2010, at 14:34, michaelld at macports.org wrote:
>
>> Revision: 72782
>>         http://trac.macports.org/changeset/72782
>> Author:   michaelld at macports.org
>> Date:     2010-10-26 12:34:05 -0700 (Tue, 26 Oct 2010)
>> Log Message:
>> -----------
>> root: addresses ticket #26984.
>> Move qt4 portgroup inclusion to the main level from inside variant.
>
> It doesn't seem like the portgroup should impose this requirement. Though granted it is most usual to include a portgroup at the top of a portfile, and less usual to be doing so conditionally.

I'm with you on all of that.  That said, including the PortGroup in this manner works for variables both inside and outside variants, as well as inside stages nested in variants (e.g., post-patch).  Including the PortGroup from inside the variant does not work as desired -- maybe because of the scope of the inclusion versus the scope of the nested stage?  IDK.  From my perspective, if it works then I go with it; I'm do not try to make it more complicated than necessary.