patches for wxwidgets-devel

[Titus von Boxberg]

Brad,

thanks for the patch.
let's keep the discussion open. Please upload your patches to trac.

I understand the patch and that is definitely a way to do it.
I did not understand yet if the patch corrects a flaw
in the wx configure script (e.g. they use a variable that
gives only the correct results if not using DESTDIR during
installation). At least, a non-macports installation does work.
If that's the case, then you should file your patch upstream to the wx guys.

I decided to tackle the problem programmatically
in the Portfile: That way it has a better chance to survive the next
wxWidgets version unchanged, and at least for me it's clearer to
see what the problem was / what the change does.

That's why I invested some time to fiddle around with Tcl
which is up to now not really a programming language I speak fluently.

I'm not the maintainer, so it's up to him or some committer to decide
if patches or Tcl code are the preferred way.
That's why it would be better that you upload the stuff to trac.

Regards
Titus

Am Do, 9.09.2010, 12:01 schrieb Bradley Giesbrecht:
> Darn, there is a typo in the patch I just sent.
>
> Use this one.
>
> // Brad
>
>
>
> On Sep 8, 2010, at 2:27 PM, Titus von Boxberg wrote:
>
>> I'm unable to apply your patch. 1 of 2 hunks fail.
>>
>> Anyway, I uploaded my approach to your ticket.
>> Maybe you want to combine the patches?
>>
>> Regards
>> Titus
>>
>> Am 08.09.2010 um 21:55 schrieb Bradley Giesbrecht:
>>
>>> Can you try this patch?
>>>
>>> http://trac.macports.org/ticket/26410
>>>
>>> // Brad
>>
>
>