[71338] trunk/dports/graphics/vtk5/Portfile

[Raphael Straub]

Rainer Müller wrote:
> On 2010-09-09 17:30 , raphael at macports.org wrote:
>> Revision: 71338
>>          http://trac.macports.org/changeset/71338
>> Author:   raphael at macports.org
>> Date:     2010-09-09 08:30:18 -0700 (Thu, 09 Sep 2010)
>> Log Message:
>> -----------
>> vtk5:
>> 
>> * collect post-destroot phases of all variants to allow combinations of these phases
> 
> For your information, it should be possible to have multiple post-phase
> blocks in the way it was before. Was there a apparent problem with the
> previous Portfile?
> 
> Unlike a normal phase block (like destroot {}), a pre- or post-phase
> block (like post-destroot {}) does not overwrite the previous
> declaration, but will append to it even if declared inside variants.

I didn't know that for sure. So, before committing my changes, I tested the new qt4_mac variant with a post-destroot block inside the variant, but the post-destroot phase was not executed. Everything was OK after collecting all post-destroot phases.

In addition, the guide <http://guide.macports.org/#development.variants.phase> explicitly says to prefer variant_isset and provides a post-destroot phase as an example.

Regards,
	Raphael