[71338] trunk/dports/graphics/vtk5/Portfile

[Raphael Straub]

Daniel J. Luke wrote:
> On Sep 9, 2010, at 12:21 PM, Raphael Straub wrote:
>> 
>> I didn't know that for sure. So, before committing my changes, I tested the new qt4_mac variant with a post-destroot block inside the variant, but the post-destroot phase was not executed. Everything was OK after collecting all post-destroot phases.
> 
> It's odd that it didn't work for you, I've done this in the past and it has worked fine.

I just checked it again. Now, it works.

>> In addition, the guide <http://guide.macports.org/#development.variants.phase> explicitly says to prefer variant_isset and provides a post-destroot phase as an example.
> 
> There are at least a few of us that feel this is bad advice in the guide.
> 
> Personally, I think variant_isset is often an indicator of something that is being done in a way that is much more complicated than necessary.

I'm of the same opinion. I just distributed the post-destroot phases again among the variants in r71342.

Regards,
	Raphael