[77883] trunk/dports/graphics/dcmtk

[Eric A. Borisch]

On Sat, Apr 16, 2011 at 6:17 AM, Ryan Schmidt <ryandesign at macports.org> wrote:
>
> On Apr 15, 2011, at 13:05, eborisch at macports.org wrote:
>
>> Revision: 77883
>>          http://trac.macports.org/changeset/77883
>> Author:   eborisch at macports.org
>> Date:     2011-04-15 11:05:57 -0700 (Fri, 15 Apr 2011)
>> Log Message:
>> -----------
>> dcmtk: Upgrade to version 3.6.0. Note that linking against dcmtk 3.6.0 may require including the new logging library (-loflog) to remedy missing log4cplus, OFLogger, or OFLog symbols.
>
>
>> -PortSystem 1.0
>> +PortSystem              1.0
>
> In the future, it would be better to make whitespace changes separately from functional changes. It would make the diff easier to review.

Will do.

>> +variant llvm description "Use llvm compiler" {
>> +  configure.compiler    llvm-gcc-4.2
>> }
>
> Isn't this variant missing a dependency on port:llvm-gcc42?

This is (at least on my system) using the xcode-provided llvm. Is
there a port for enforcing that, or is a file dependency the best
route.

On a related note, I found with further testing that the prior version
of dcmtk needs to be deactivated before this one can be built. Is
there a best practice for informing (and enforcing) this requirement?

Thanks,
 Eric