[77883] trunk/dports/graphics/dcmtk

[Eric A. Borisch]

On Sat, Apr 16, 2011 at 7:19 PM, Ryan Schmidt <ryandesign at macports.org> wrote:
> Sending reply back to list...
>
> On Apr 16, 2011, at 07:57, Eric A. Borisch wrote:
>
>> On Sat, Apr 16, 2011 at 6:17 AM, Ryan Schmidt wrote:
>>>> +variant llvm description "Use llvm compiler" {
>>>> +  configure.compiler    llvm-gcc-4.2
>>>> }
>>>
>>> Isn't this variant missing a dependency on port:llvm-gcc42?
>>
>> This is (at least on my system) using the xcode-provided llvm. Is
>> there a port for enforcing that, or is a file dependency the best
>> route.
>
> Ah, you're right, I got mixed up. You're right, "configure.compiler llvm-gcc-4.2" means Mac OS X's llvm-gcc, while "configure.compiler macports-llvm-gcc-4.2" is the one in the llvm-gcc42 port. No, there's no dependency you need to add in that case. Although you should prevent the variant from being used on operating system versions that don't have llvm.
>

Implemented in https://trac.macports.org/changeset/77982

>> On a related note, I found with further testing that the prior version
>> of dcmtk needs to be deactivated before this one can be built. Is
>> there a best practice for informing (and enforcing) this requirement?
>
> That's tricky. It would be best to fix the problem, if possible. Usually this is caused by -I or -L arguments in the wrong order (system directory precedes build directory). Possibly, simply clearing the default configure.ldflags and/or configure.cppflags is the solution, but ensure this doesn't result in linking to system libraries instead of MacPorts libraries or missing some libraries entirely.

Also implemented in https://trac.macports.org/changeset/77982

Thanks for the suggestions!
 --Eric
-- 
Eric A. Borisch