[78061] trunk/dports/devel/premake/Portfile

[Ryan Schmidt]

On Apr 21, 2011, at 16:04, wyuenho at macports.org wrote:

> Revision: 78061
>          http://trac.macports.org/changeset/78061
> Author:   wyuenho at macports.org
> Date:     2011-04-21 14:04:08 -0700 (Thu, 21 Apr 2011)
> Log Message:
> -----------
> updated premake to 3.7

You also made whitespace changes; we'd like to see whitespace changes as separate commits from functional changes, so functional changes can be more easily reviewed.

You also switched from downloading the source and building it, to downloading and installing a binary. Why this change? MacPorts is a build-from-source package manager, deviating only when source is not available or cannot be easily compiled. In this case also, the binary you downloaded is compiled for i386 and ppc7400, whereas before the port would build for x86_64 on Snow Leopard. If possible, please go back to building from source as before. Also please add code for respecting the user's build_arch, and add a universal variant.


> 
> Modified Paths:
> --------------
>    trunk/dports/devel/premake/Portfile
> 
> Modified: trunk/dports/devel/premake/Portfile
> ===================================================================
> --- trunk/dports/devel/premake/Portfile	2011-04-21 20:02:17 UTC (rev 78060)
> +++ trunk/dports/devel/premake/Portfile	2011-04-21 21:04:08 UTC (rev 78061)
> @@ -1,24 +1,32 @@
> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
> # $Id$
> 
> -PortSystem 1.0
> -name		premake
> -version		3.5
> -categories	devel
> -maintainers	wyuenho
> -description	Premake is a build script generator.
> -long_description	Premake is a build script generator. Describe your \
> -			project using the full-featured Lua scripting language \
> -			and use premake to create input files for various IDEs \
> -      and GnuMake
> -platforms	darwin
> -homepage	http://premake.sourceforge.net/
> -master_sites	sourceforge
> -distname	${name}-src-${version}
> -use_zip		yes
> -checksums	md5 b2fb3a8a5e1f85309432e5814b232d9f
> -worksrcdir	Premake-${version}
> -use_configure	no
> +PortSystem          1.0
> 
> +name                premake
> +version             3.7
> +
> +categories          devel
> +maintainers         wyuenho openmaintainer
> +description         Premake is a build script generator.
> +long_description    Premake is a build script generator. Describe your \
> +                    project using the full-featured Lua scripting language \
> +                    and use premake to create input files for various IDEs \
> +                    and GnuMake
> +
> +platforms           darwin
> +
> +homepage           http://premake.sourceforge.net/
> +
> +master_sites       sourceforge
> +distname           ${name}-macosx-${version}
> +checksums          md5      0bb35787305f919c6fed61511ce293ac \
> +                   sha1     69855682ea5608a4ac84ce21f66d4a7534263e82 \
> +                   rmd160   1dea3fd336b150b7f1553bc62f51ff22344b613c
> +use_configure      no
> +
> +build {}
> +
> destroot	{
> -		file copy ${worksrcpath}/bin/premake ${destroot}${prefix}/bin/
> +		file copy ${workpath}/premake ${destroot}${prefix}/bin/
> }