[82787] trunk/dports/science/scotch/Portfile

[Ryan Schmidt]

On Aug 20, 2011, at 02:46, mk at macports.org wrote:

> Revision: 82787
>          http://trac.macports.org/changeset/82787
> Author:   mk at macports.org
> Date:     2011-08-20 00:46:55 -0700 (Sat, 20 Aug 2011)
> Log Message:
> -----------
> science/scotch: follow Ryan's advice and use get_canonical_archflags and skip post-install message concerning currently missing man pages
> 
> Modified Paths:
> --------------
>    trunk/dports/science/scotch/Portfile
> 
> Modified: trunk/dports/science/scotch/Portfile
> ===================================================================
> --- trunk/dports/science/scotch/Portfile	2011-08-20 03:34:39 UTC (rev 82786)
> +++ trunk/dports/science/scotch/Portfile	2011-08-20 07:46:55 UTC (rev 82787)
> @@ -5,6 +5,8 @@
> 
> name                scotch
> version             5.1.11
> +revision            1

Since this did not change the files that get installed on the user's hard drive, the revision increase was not warranted.


> # this is specific to this port and *version* for downloading it:
> set release         28043
> 
> @@ -37,11 +39,7 @@
> variant universal {
> }
> 
> -if {[variant_isset universal]} {
> -    set archflags ${configure.universal_cflags}
> -} else {
> -    set archflags ${configure.cc_archflags}
> -}
> +set archflags       [get_canonical_archflags]

I would just dispense with the archflags variable entirely. Just call [get_canonical_archflags] directly wherever you want to use it:

CFLAGS="${configure.cflags} [get_canonical_archflags]" \
CXXFLAGS="${configure.cxxflags} [get_canonical_archflags]" \
LDFLAGS="[join ${configure.ldflags}] [get_canonical_archflags]"