[83049] trunk/dports/lang/ecl/Portfile

[Ryan Schmidt]

On Aug 24, 2011, at 15:06, easieste at macports.org wrote:

> Revision: 83049
>          http://trac.macports.org/changeset/83049
> Author:   easieste at macports.org
> Date:     2011-08-24 13:06:30 -0700 (Wed, 24 Aug 2011)
> Log Message:
> -----------
> A working post ecl-11.1 from git under OS X Lion.
> 
> Modified Paths:
> --------------
>    trunk/dports/lang/ecl/Portfile
> 
> Modified: trunk/dports/lang/ecl/Portfile
> ===================================================================
> --- trunk/dports/lang/ecl/Portfile	2011-08-24 18:42:05 UTC (rev 83048)
> +++ trunk/dports/lang/ecl/Portfile	2011-08-24 20:06:30 UTC (rev 83049)
> @@ -20,3 +20,14 @@
>                     sha1    9c4c88683f6186f8152866033e6850e19eb8cc1f \
>                     rmd160  e15dd8cf02cd6ad78ef35293df014363615fd4ad
> use_parallel_build	no
> +
> +platform darwin 11 {
> +         fetch.type             git    
> +         git.url                git://ecls.git.sourceforge.net/gitroot/ecls/ecl
> +         git.branch             24eb6a44bc842d3d7ee52fb93f638340176ce552
> +         configure.compiler     gcc-4.2
> +         build.args-append      CC=${configure.cc} \
> +                                CXX=${configure.cxx} \
> +                                CPP=${configure.cpp} 
> +}

It's not 11.1.1, but you're still installing it as if it were 11.1.1 (by not changing the version field)? Yuck.

If there are really so many changes from 11.1.1 that they could not be expressed as a patchfile, this really should have been a new ecl-devel port instead.

Why is setting CC, CXX, CPP only applicable here and not in the portfile generally?