[83030] trunk/dports/devel/griffon/Portfile

[Ryan Schmidt]

On Aug 23, 2011, at 23:53, breskeby at macports.org wrote:

> Revision: 83030
>          http://trac.macports.org/changeset/83030
> Author:   breskeby at macports.org
> Date:     2011-08-23 21:53:15 -0700 (Tue, 23 Aug 2011)
> Log Message:
> -----------
> griffon: version upgrade to 0.9.3
> 
> Modified Paths:
> --------------
>    trunk/dports/devel/griffon/Portfile


> -worksrcdir          ${name}-${version}
> +worksrcdir          .
> set workTarget      ""
> -
> use_configure       no
> 
> build.cmd           true
> 
> pre-destroot {
>     # Remove extraneous bat files
> -    foreach f [glob -directory ${worksrcpath}/bin *.bat] {
> +    foreach f [glob -directory ${worksrcpath}${workTarget}/griffon-${version}/bin *.bat] {
>         file delete $f
>     }
> }
> @@ -47,19 +47,20 @@
>     xinstall -m 755 -d ${destroot}${prefix}/share/java/${name}
> 
>     # Copy over the needed elements of our directory tree
> -    file copy ${worksrcpath}/bash		\
> -              ${worksrcpath}/conf		\
> -              ${worksrcpath}/dist		\
> -              ${worksrcpath}/INSTALL	\
> -              ${worksrcpath}/lib		\
> -              ${worksrcpath}/LICENSE	\
> -              ${worksrcpath}/media		\
> -              ${worksrcpath}/scripts	\
> +    file copy ${worksrcpath}/griffon-${version}/bash					\
> +              ${worksrcpath}/griffon-${version}/conf					\
> +              ${worksrcpath}/griffon-${version}/dist					\
> +              ${worksrcpath}/griffon-${version}/INSTALL					\
> +              ${worksrcpath}/griffon-${version}/lib						\
> +              ${worksrcpath}/griffon-${version}/LICENSE					\
> +              ${worksrcpath}/griffon-${version}/media					\
> +              ${worksrcpath}/griffon-${version}/src						\
> +              ${worksrcpath}/griffon-${version}/scripts					\
>               ${destroot}${prefix}/share/java/${name}/
> 
> 	xinstall -m 755 -d ${destroot}${prefix}/share/java/${name}/bin
> -	eval xinstall -m 755 [glob ${worksrcpath}/bin/*] ${destroot}${prefix}/share/java/${name}/bin   
> -
> +	eval xinstall -m 755 [glob ${worksrcpath}/griffon-${version}/bin/*] ${destroot}${prefix}/share/java/${name}/bin   

Why all these changes, which seems to do nothing other than make the portfile more complicated and harder to understand? I suggest you undo them, and remove the then-unused workTarget variable, and the portfile can be much simpler again. And the same simplification can be made to griffon-devel too.