[83340] trunk/dports/graphics/librsvg/Portfile

[Ryan Schmidt]

On Aug 29, 2011, at 21:57, pixilla at macports.org wrote:

> Revision: 83340
>          http://trac.macports.org/changeset/83340
> Author:   pixilla at macports.org
> Date:     2011-08-29 19:57:54 -0700 (Mon, 29 Aug 2011)
> Log Message:
> -----------
> graphics/librsvg:
> - Claim maintainer.
> - Add svg2pdf script.
> - See #27887.
> 
> Modified Paths:
> --------------
>    trunk/dports/graphics/librsvg/Portfile

> +post-build {
> +    xinstall -d ${buildpath}
> +    set fp [open ${buildpath}/svg2pdf w]
> +    puts $fp "#!/bin/sh"
> +    puts $fp "if [ $# -lt 2 -o \"$1\" = \"-h\" -o \"$1\" = \"--help\" ] ; then"
> +    puts $fp "	echo \"FAIL: usage: $0 input_file.svg output_file.pdf\""
> +    puts $fp "	exit 255;"
> +    puts $fp "fi"
> +    puts $fp "rsvg-convert -f pdf -o \"$2\" \"$1\""
> +    close $fp
> +}

It might be simpler to just have a file in the files directory containing the script.


> +    xinstall -m 755 -W ${buildpath} svg2pdf \
> +        ${destroot}${prefix}/sbin

It's not a server binary; it is a program the user is intended to run directly. As such, shouldn't it be in ${prefix}/bin instead?