[75880] trunk/dports/graphics/makeicns/Portfile

[Ryan Schmidt]

On Feb 11, 2011, at 16:02, mk at macports.org wrote:

> Revision: 75880
>          http://trac.macports.org/changeset/75880
> Author:   mk at macports.org
> Date:     2011-02-11 14:01:59 -0800 (Fri, 11 Feb 2011)
> Log Message:
> -----------
> makeicns: get sources now from download section to avoid trouble with checksum changes of dist files supplied by bitbucket via /get, append to build.env, update maintainers, use version 1.4.1 due to minor changes

> -distname            ${version}
> +distname            ${name}-${version}

This can be deleted; this is the default.


> @@ -39,16 +40,14 @@
> } else {
>     set archflags ${configure.cc_archflags}
> }
> +
> +build.env-append    CC=${configure.cc} \
> +                    CXX=${configure.cxx}
> +
> if {${configure.sdkroot} != ""} {
> -    configure.ldflags-append "-isysroot ${configure.sdkroot}"
> +    build.env-append SDK=${configure.sdkroot}
> }
> 
> -build.env           CC=${configure.cc} \
> -                    CXX=${configure.cxx} \
> -                    CFLAGS="${configure.cflags} ${archflags}" \
> -                    CXXFLAGS="${configure.cxxflags} ${archflags}" \
> -                    LDFLAGS="[join ${configure.ldflags}] ${archflags}"

What happened to the archflags? Now you're not respecting build_arch or universal_archs anymore.

The universal variant where the port sets the environment variable BUILD_UNIVERSAL to yes can also be removed. Everything the Makefile does in response to that environment variable (i.e. setting its own arch flags) is inapplicable within the context of MacPorts. Just make it an empty universal variant, then handle the archflags as you'd been handling them in the previous version of the port, or add the archflags to CC and CXX, as many other ports do. Don't forget to increase the revision when you make this change, so those who already built the port now with the wrong architectures will be prompted to rebuild.