[76337] trunk/dports/science/smodels/Portfile

Jeremy Lavergne jeremy at lavergne.gotdns.org
Sun Feb 20 03:20:54 PST 2011

> But mightn't these reinplaces be better handled as a combo patchfile-with-placeholders / reinplace-placeholders-with-values? In particular the CXXFLAGS -- what if upstream later changes the CXXFLAGS in the Makefile slightly? Unless your MacPorts base is patched to include the patch from #15514, your reinplace will then silently fail, whereas if you use a patchfile, you'll get notification and immediate port failure, which is good because it gives you the chance to fix it; it also gives you context around the line in question, so that you can more easily find the corresponding section in the revised source file.

Sounds like we should be putting that patch into base, no? Either way, thanks for the patchfile suggestion :-)

>> +use_configure       no
> This means you'll need to manually deal with build_arch and UsingTheRightCompiler.

Unfortunately there's no configure file.

Looks like I'll have to plop in code to handle the arch flags (and patching them into the Makefile likely). Wee.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3749 bytes
Desc: not available
URL: <http://lists.macosforge.org/pipermail/macports-dev/attachments/20110220/edd172ed/attachment.bin>

More information about the macports-dev mailing list