[76513] trunk/dports/math/atlas/Portfile

[Joshua Root]

On 2011-2-27 08:42 , vincent habchi wrote:
> Hi Josh,
> 
>>> +if {${build_arch} == "ppc"} {
>>> +    configure.args-delete	--cc=${configure.cc} \
>>> +    						-Fa alg -fPIC
>>> +
>>> +	configure.args-append	--cc='${configure.cc} -m32' \
>>> +    						-Fa alg '-fPIC -m32'
>>> +}
>>
>> Why not use ${configure.cc_archflags} all the time? Also, won't this
>> break universal?
> 
> You mean writing something like --cc='${configure.cc} -${configure.cc_archflags}'?

Wherever you are checking the value of $build_arch and adding a
hardcoded -m32 now, you could use ${configure.cc_archflags} instead.
When using a non-apple configure.compiler it will be either -m32 or -m64
depending on $build_arch.

> Could you be more specific on why it should break universal?

You're adding -m32 which is only correct for half of the build. You at
least need to only add it when ![variant_isset universal].

- Josh