[75337] trunk/dports/science/ncarg/Portfile

Takeshi Enomoto takeshi at macports.org
Sat Jan 22 23:31:05 PST 2011


>> Modified: trunk/dports/science/ncarg/Portfile
>> +    reinplace "s|int_p_NULL|(int*)NULL|g" ${worksrcpath}/ncarg2d/src/libncarg/ezmap/mapngb.c
> This is exactly the kind of change that would be more appropriately made as a patchfile, not a reinplace.

Thank you for a good suggestion. I had thought that the fewer patches the better.
It is difficult for the upstream developer to read Portfile but diffs.

> It is better to write commit messages that say what you did, not just what ticket to look at for details.

Yes, you are right. It is easier to read the commit comment  in the command-line than finding corresponding Trac tickets.


More information about the macports-dev mailing list