[80817] trunk/dports/php

[Ryan Schmidt]

On Jul 18, 2011, at 13:25, jmr at macports.org wrote:

> Revision: 80817
>          http://trac.macports.org/changeset/80817
> Author:   jmr at macports.org
> Date:     2011-07-18 11:25:48 -0700 (Mon, 18 Jul 2011)
> Log Message:
> -----------
> New port: php5-shindig (#25839)
> 
> Added Paths:
> -----------
>    trunk/dports/php/php5-shindig/
>    trunk/dports/php/php5-shindig/Portfile
> 
> Added: trunk/dports/php/php5-shindig/Portfile
> ===================================================================
> --- trunk/dports/php/php5-shindig/Portfile	                        (rev 0)
> +++ trunk/dports/php/php5-shindig/Portfile	2011-07-18 18:25:48 UTC (rev 80817)
> @@ -0,0 +1,43 @@
> +# $Id$
> +
> +PortSystem 1.0
> +
> +name            php5-shindig
> +version         2.0.0
> +categories      php www
> +maintainers     yahoo.com:bm55b openmaintainer
> +description     Open Social Container
> +long_description        \
> +        Shindig is the Apache.org implementation of the Open Social spec. \
> +        Shindig has a PHP and a Java implementation. \
> +        This package is the PHP implementation.
> +homepage        http://shindig.apache.org/
> +platforms       darwin
> +supported_archs noarch
> +master_sites    apache:shindig/${version}/
> +distname        shindig-${version}-php
> +use_bzip2       yes
> +checksums       md5 f26290bb8a50b6f723caa85693ed29a4                \
> +                sha1 0593800eff48650b49bafb10c010e24dbd01e9bb       \
> +                rmd160 24999cbf1139e8184109561fe7497d48d7dc8371
> +
> +#depends_run     port:php5-mcrypt port:php5-curl port:php5-openssl
> +
> +use_configure   no
> +
> +build {}
> +
> +destroot {
> +    set wwwdir ${prefix}/apache2/htdocs/shindig
> +    xinstall -d ${destroot}${wwwdir}
> +    foreach file [glob ${worksrcpath}/*] {
> +        copy ${file} ${destroot}${wwwdir}
> +    }

Why install in such a complicated manner? Why not just:

xinstall -d ${destroot}${prefix}/apache2/htdocs
copy ${worksrcpath} ${destroot}${prefix}/apache2/htdocs/shindig


> +    # fix privs on a few files and install .htaccess
> +    file delete ${destroot}${wwwdir}/NOTICE ${destroot}${wwwdir}/README
> +    xinstall -m 644 ${worksrcpath}/NOTICE \
> +        ${worksrcpath}/README \
> +        ${worksrcpath}/.htaccess \
> +        ${destroot}${wwwdir}
> +}


Why copy a file, then delete it, then copy it again? You can fix permissions on an already-copied file using "file attributes".