[76933] trunk/dports/multimedia/VLC

[Joshua Root]

On 2011-3-14 16:24 , Ryan Schmidt wrote:
> On Mar 14, 2011, at 00:04, Joshua Root wrote:
> 
>> On 2011-3-14 15:02 , Ryan Schmidt wrote:
>>>
>>
>>> On Mar 13, 2011, at 22:45, Jeremy Huddleston wrote:
>>>
>>>> On Mar 13, 2011, at 17:36, Ryan Schmidt wrote:
>>>>
>>>>> That's not how default_variants works. You don't use -append, and you do need to prefix each variant name with a "+".
>>>>>
>>>>> default_variants +qtcapture +auhal
>>>>
>>>> I understand I made a mistake without the +, but why not the -append?  The VLC port is already doing that elsewhere (in the x11 case) and it seems to be behaving correctly, so why is that wrong?
>>>
>>> I'm not sure, but it seemed to me that default_variants was not a variable that gets appended to or deleted from, but is a command that, when executed, appends (or maybe prepends) the given variants to the selected variants. I don't know why it behaves that way, it's just what I observed.
>>>
>>> If the port already has bits in it that append to default_variants, then I don't know why that works either.
>>
>> Using default_variants-append is not wrong. It's only because
>> default_variants is implemented kind of weirdly that *not* using -append
>> still adds rather than clobbering.
> 
> Well, default_variants-delete doesn't work. So I would avoid using default_variants-append, since it falsely implies that default_variants has the normal -append/-delete semantics.

Having it act like an option at all implies that. So how about fixing
the XXX [1] rather than making port authors not use a working feature?

[1]
<http://trac.macports.org/browser/trunk/base/src/port1.0/portutil.tcl#L2026>