[77131] trunk/dports/sysutils/zeroinstall-injector

Anders F Björklund afb at macports.org
Mon Mar 21 03:51:14 PDT 2011


Ryan Schmidt wrote:

>> Revision: 77131
>>         http://trac.macports.org/changeset/77131
>> Author:   afb at macports.org
>> Date:     2011-03-20 09:53:17 -0700 (Sun, 20 Mar 2011)
>> 

>> -patchfiles	patch-setup.py
>> +post-patch   {
>> +	reinplace "s|'man/man1'|'share/man/man1'|" ${worksrcpath}/setup.py
>> +}
> 
> Aren't patchfiles preferable over reinplaces?

Once they trivially fail to apply enough times, not really ?
(just because something else was added to the packaging list)

Especially this one, with that messy old "share/man" food fight
between /usr/share/man and /usr/local/man that Doesn't Matter...


The post-destroot is equally debatable; should it be post-patch ?
No, it shouldn't. Since the shebangs are mangled during the install.
Just that distutils misses things that are not installed as "scripts".
But that's fixed upstream now, maybe the manpage could be as well...

--anders



More information about the macports-dev mailing list