[77188] contrib/cpan2port/cpan2port

[Ryan Schmidt]

On Mar 21, 2011, at 23:23, l2g at macports.org wrote:

> Revision: 77188
>          http://trac.macports.org/changeset/77188
> Author:   l2g at macports.org
> Date:     2011-03-21 21:23:29 -0700 (Mon, 21 Mar 2011)
> Log Message:
> -----------
> Finesse the output a little more; include supported_archs and long_description
> (just fallback values for now)
> 
> Modified Paths:
> --------------
>    contrib/cpan2port/cpan2port


> +supported_archs     noarch

Always putting "supported_archs noarch" into the generated portfile is just as bad as not putting anything. There are plenty of Perl modules that do install architecture-specific compiled software, and using "supported_archs noarch" on those would be incorrect.

If you're going to have cpan2port insert this line, have it do so only when the specific port in fact does not install architecture-specific files. If cpan2port doesn't have enough information to make that determination, then I wouldn't put the line into the portfile. (Or, maybe, you could put it into the portfile commented out, with an additional comment above it explaining to the maintainer how to decide whether to uncomment it or remove it.)