[87169] trunk/dports/python

[Ryan Schmidt]

On Nov 12, 2011, at 15:01, mmoll at macports.org wrote:

> Revision: 87169
>          http://trac.macports.org/changeset/87169
> Author:   mmoll at macports.org
> Date:     2011-11-12 13:01:33 -0800 (Sat, 12 Nov 2011)
> Log Message:
> -----------
> new port: py-graph-tool

> +if {$subport != $name} {
> +    depends_lib-append port:boost \
> +                       port:cgal \
> +                       port:expat \
> +                       port:graphviz \

Dependency on graphviz should be written so that graphviz-devel could satisfy it (i.e. "path:bin/dot:graphviz"). See #14540.


> +    if {${configure.compiler} == "clang"} {
> +        configure.compiler llvm-gcc-4.2
> +    }
> +    if {${configure.compiler} == "llvm-gcc-4.2" || 
> +        ${configure.compiler} == "gcc-4.0" ||
> +        ${configure.compiler} == "gcc-4.2" ||
> +        ${configure.compiler} == "apple-gcc-4.0" ||
> +        ${configure.compiler} == "apple-gcc-4.2" ||
> +        ${configure.compiler} == "macports-gcc-4.1" ||
> +        ${configure.compiler} == "macports-gcc-4.2" ||
> +        ${configure.compiler} == "macports-gcc-4.3"} {
> +        configure.cxxflags-append -DCGAL_CFG_NO_CPP0X_VARIADIC_TEMPLATES
> +    }

I suppose this is thorough but I'm unclear under what circumstances you think that, for example, the macports-gcc-4.3 compiler would ever be used for this port.

> +}
> +
> +# not supported by clang at the moment

Which isn't a problem since you've already specified above that clang will never be used.

> +variant openmp description {Add support for openmp} {
> +    configure.args-append --enable-openmp
> +}
> +
> +post-destroot {
> +    xinstall -d ${destroot}${python.pkgd}
> +    file rename ${destroot}${prefix}/lib/python${python.branch}/site-packages/graph_tool \
> +        ${destroot}${python.pkgd}
> +    file rename ${destroot}${prefix}/doc/graph-tool \
> +        ${destroot}${prefix}/share/doc/graph-tool 
> +}

The variant and the post-destroot block need to be inside the "if {$subport != $name}" check.