[87157] trunk/dports/devel/pficommon

[Hiroshi Umemoto]

On Nov 13, 2011, at 2:04 AM, Ryan Schmidt wrote:
> On Nov 12, 2011, at 09:28, hum at macports.org wrote:
>> 
>> Modified Paths:
>> --------------
>>   trunk/dports/devel/pficommon/Portfile

>> +variant mysql description {Enable mysql} {
>> +    depends_lib-append    lib:mysql_config:mysql5
>> +    configure.args-delete --disable-mysql
>> +}
>> +
>> +variant postgresql description {Enable postgresql} {
>> +    depends_lib-append    lib:libpq:postgresql91
>> +    configure.args-delete --disable-postgresql
>> +}
> 
> You should use path:- or port:-style dependencies. lib:- and bin:-style dependencies would allow dependencies installed by the user outside of MacPorts to satisfy them, which we don't want.
> 
> You also probably need to tell the configure script how to find these versions of MySQL and PostgreSQL since they're both installed in nonstandard locations.

Thank you for your comments.
Actually, I do not care about which version of the databases the port depends on, which are installed either inside or outside of MacPorts. Especially, PostgreSQL 9.0.4 is pre-installed on Lion (10.7.2), and I think we do not have to install it with MacPorts all the way.

>> +variant magickpp description {Enable magick++} {
>> +    depends_lib-append    port:imagemagick
>> +    configure.args-delete --disable-magickpp
>> +}
> 
> The port is called ImageMagick, not imagemagick.

I will fix it. Thanks.