[87295] trunk/dports/databases

[Joshua Root]

On 2011-11-17 07:09 , Ryan Schmidt wrote:
> On Nov 16, 2011, at 12:23, jwa at macports.org wrote:
> 
>> Revision: 87295
>>          http://trac.macports.org/changeset/87295
>> Author:   jwa at macports.org
>> Date:     2011-11-16 10:23:45 -0800 (Wed, 16 Nov 2011)
>> Log Message:
>> -----------
>> new port, at 5.0.1
> 
> Remember to begin your commit message with the port name.

It doesn't have to begin with it, just mention it.

>> Added Paths:
>> -----------
>>    trunk/dports/databases/libgda5/
>>    trunk/dports/databases/libgda5/Portfile
> 
> 
>> +if (![variant_isset without_bdb]) {
>> +    if !([file exists ${prefix}/include/db46/db.h]) {
>> +        depends_lib-append port:db47
>> +    } elseif ([file exists ${prefix}/include/db47/db.h])  {
>> +        depends_lib-append port:db47
>> +    } else {
>> +        depends_lib-append port:db46
>> +    }
>> +}
> 
> I'm surprised this works syntactically; I've never seen parentheses used in Tcl in "if" statements. Everywhere else, we use curly braces.

The braces are just to group the expression, which possibly contains
spaces, into a single string to pass as the first argument to 'if'.
Parentheses override the normal order of operations inside the
expression and thus do nothing in this case.

- Josh