[84826] trunk/dports/devel

[Ryan Schmidt]

On Oct 3, 2011, at 09:44, Andrea D'Amore wrote:

> On Mon, Oct 3, 2011 at 03:20, Ryan Schmidt wrote:
> 
>>> +use_configure       no
>>> +variant universal {}
> 
>> I don't have Lion to test this with, but are you sure this works?
> 
> Actually I borrowed that from existing nu's portfile.

You can't just borrow the line "variant universal {}" (which adds an empty universal variant that does nothing) and then not borrow the rest of the lines that actually make that variant do something:

patchfiles          patch-Makefile.diff patch-Nukefile.diff

post-patch {
    if {[variant_isset universal]} {
        set archs ${configure.universal_archs}
    } else {
        set archs ${configure.build_arch}
    }
    reinplace "s|@ARCHS@|[join ${archs} {" "}]|g" ${worksrcpath}/Nukefile



> I just tested it again: nu2 builds fine boths i386 and x86_64 in Lion.
> The Nu script (Lisp like) set target archs by its own and ii's not
> checking env variables so the port doesn't provide single architecture
> or +universal flavors.
> It can be patched if needed but nu2's dependencies are quite small.
> 
> Check r84840.

The Nu2 port needs to respect the user's architecture choices by using the build_arch or universal_archs variables as appropriate -- like the nu port already does.