[85096] users/cal/ports

[Ryan Schmidt]

On Oct 9, 2011, at 15:39, cal at macports.org wrote:

> Revision: 85096
>          http://trac.macports.org/changeset/85096
> Author:   cal at macports.org
> Date:     2011-10-09 13:39:08 -0700 (Sun, 09 Oct 2011)
> Log Message:
> -----------
> user port: x11/herbstluftwm

I know this is still a work in progress, but a couple comments:


> Added: users/cal/ports/x11/herbstluftwm/Portfile

> +depends_lib             port:glib2 \

Dependencies on ports that have -devel versions should be written in such a way that the -devel version could also satisfy it. See other ports that depend on glib2 for examples, or the preliminary documentation in #14540:

https://trac.macports.org/ticket/14540


> +destroot.args-append    PREFIX=${destroot}/${prefix} \
> +                        ETCDIR=${destroot}/${prefix}/etc/ \

${prefix} already begins with a "/", so you shouldn't put another "/" in front of ${prefix}.


> Added: users/cal/ports/x11/herbstluftwm/files/config.patch

> + # paths
> +-X11INC = /usr/X11R6/include
> +-X11LIB = /usr/X11R6/lib
> ++X11INC = /opt/local/include/X11
> ++X11LIB = /opt/local/lib

You shouldn't hardcode /opt/local; try using $(PREFIX).