[85929] trunk/base/src/port1.0/portlint.tcl

[Ryan Schmidt]

On Oct 17, 2011, at 13:19, snc at macports.org wrote:

> Revision: 85929
>          http://trac.macports.org/changeset/85929
> Author:   snc at macports.org
> Date:     2011-10-17 11:19:31 -0700 (Mon, 17 Oct 2011)
> Log Message:
> -----------
> base: if set, check license formatting
> 
> Modified Paths:
> --------------
>    trunk/base/src/port1.0/portlint.tcl
> 
> Modified: trunk/base/src/port1.0/portlint.tcl
> ===================================================================
> --- trunk/base/src/port1.0/portlint.tcl	2011-10-17 17:53:36 UTC (rev 85928)
> +++ trunk/base/src/port1.0/portlint.tcl	2011-10-17 18:19:31 UTC (rev 85929)
> @@ -504,6 +504,30 @@
>     if {$license == "unknown"} {
>         ui_warn "no license set"
>         incr warnings
> +    } else {
> +
> +        # If maintainer set license, it must follow correct format
> +
> +        # Apache 2 is illegal, use Apache-2
> +        if {[regexp {[A-Za-z] [0-9]} $license]} {
> +            ui_error "Invalid license format: use a hyphen between name and version"
> +        }

What about "W3C" which is a valid license?

I think it should only complain if there's a digit at the *end* of the license (excepting "X11").