[83549] trunk/dports/math
Joshua Root
jmr at macports.org
Tue Sep 6 04:42:23 PDT 2011
On 2011-9-6 18:15 , Ryan Schmidt wrote:
>
> On Sep 6, 2011, at 03:10, Markus W. Weißmann wrote:
>
>> On 5 Sep 2011, at 23:16, Ryan Schmidt wrote:
>>
>> ...
>>
>>> Also add the standard modeline, and ensure the port conforms to it. (Your port does not: it includes a mixture of tabs and spaces for whitespace; we want all spaces.)
>>>
>>
>> do you need a modeline if its all spaces anyway?
>
> It would not be correct to list the modeline unless the file actually conformed to it (i.e. used all spaces).
>
> Yes, all files should ideally have modelines.
The actual policy as per HACKING is:
* Portfiles SHOULD use soft tabs at a tabstop of 4, but implementation
of this is left up to the discretion of the maintainer.
* Portfiles SHOULD use the given modeline
Note it says SHOULD, not MUST.
- Josh
More information about the macports-dev
mailing list