Ignore MisbehavingServers rather than fail with an error

[Joshua Root]

On 2012-4-8 22:02 , Arno Hautala wrote:
> I think the proxy issue is if there is an error on the user's end
> (misconfigured proxy, unacknowledged hotel wireless terms, etc.) this
> change could lead to port downloading from multiple sources and
> reporting that each is misbehaving. The correct fix in this case is on
> the user.
> 
> Downloading multiple times is a waste, but shouldn't be too heavy.
> It's not like this would download the full distfile and the HTML error
> page every time. You could always cache the checksum for the previous
> fetch and then report to the user that it may be a misbehaving server
> / bad proxy if subsequent fetches match. Though I can see how a bad
> proxy wouldn't necessarily deliver the exact same payload every time.
> In my opinion, grabbing an error page from every mirror server before
> reporting a misbehaving server isn't an unacceptable option.

The patch doesn't report a misbehaving server in this case, it makes
fetching fail for no discernable reason.

Applying restrictions to what distfiles may contain before you even know
that the checksums don't match is an incorrect approach.

- Josh