[92004] trunk/dports/lang

[Ryan Schmidt]

On Apr 15, 2012, at 17:06, takeshi at macports.org wrote:

> Revision: 92004
>          https://trac.macports.org/changeset/92004
> Author:   takeshi at macports.org
> Date:     2012-04-15 15:06:29 -0700 (Sun, 15 Apr 2012)
> Log Message:
> -----------
> omnixmp: adding XcalableMP
> 


> +homepage            http://www.xcalablemp.org/
> +platforms           darwin
> +master_sites        ${homepage}/xmp_files/

To avoid the double slash in the download URL, use:

master_sites        ${homepage}xmp_files/


> +post-patch {
> +    if {${build_arch}=="x86_64"} {
> +        reinplace "s|CPU=i386|CPU=x86_64|g" ${worksrcpath}/configure
> +    }
> +}

The configure script hardcodes CPU=i386? Does this port work on PowerPC Macs then? If not, the port should state "supported_archs i386 x86_64".


> +configure.args      --prefix=${prefix}/lib/${name} \

To avoid having two different --prefix arguments, use:

configure.pre_args --prefix=${prefix}/lib/${name}


> +depends_lib         port:openmpi \
> +                    port:flex \
> +                    port:gmp \
> +                    port:libxml2

> +variant g95 conflicts gcc44 gcc45 description {use g95 as backend fortran compiler} {
> +    depends_lib     port:g95
> +    configure.fc    ${prefix}/bin/g95
> +}
> +
> +variant gcc44 conflicts g95 gcc45 description {use gfortran-mp-4.4 as backend fortran compiler} {
> +    depends_lib     port:gcc44
> +    configure.compiler  macports-gcc-4.4
> +}
> +
> +variant gcc45 conflicts g95 gcc44 description {use gfortran-mp-4.5 as backend fortran compiler} {
> +    depends_lib         port:gcc45
> +    configure.compiler  macports-gcc-4.5
> +}

The dependencies in these variants override the port's global dependencies. Use depends_lib-append in the variants instead. The port's revision should be increased when you do this so the dependencies are recorded correctly in all users' registries.