gnuplot 4.6: request to review the patch

[Mojca Miklavec]

Dear Developers,

On Wed, Apr 11, 2012 at 03:21, Mojca Miklavec wrote:
> Dear MacPorts developers,
>
> I would like to request if somebody could review the patches to
> upgrade Gnuplot to 4.6.0.
>
>    https://trac.macports.org/attachment/ticket/33596/gnuplot4_6_0-v2.diff
>    https://trac.macports.org/attachment/ticket/33596/gnuplot4_6_0-v2-cocoa.diff

I would like to kindly request if somebody could take a look, test and
feel free to ask any additional questions if there are any. The two
patches do exactly the same thing, except that one uses Cocoa and the
other one uses Carbon to call a function that removes a program from
Dock. (Diff on ./configure has been auto-generated with autotools and
its complexity may be ignored.) I would go for Cocoa, but I have no
strong opinion about that. And if somebody has some good reasons for
either one or the other, I'll ask gnuplot developers to take the
selected patch upstream.


I have some additional more simple patches on the stack (some already
written, some waiting to be written), but I don't want to keep them
around as "patches of patches of patches". This is why it would really
really help to get some feedback and get gnuplot 4.6.0 included, so
that I can continue contributing smaller & less important patches.

Thank you,
    Mojca

PS: I would also like to ask somebody to close this ticket:
    https://trac.macports.org/ticket/33917
(it is not related to gnuplot at least; if there is a problem that
could easily be fixed in core to trigger automatic updates when they
are needed, the ticket should be reassigned to macports core, else
simply closed).