[96177] trunk/dports/lang

[Christoph Iserlohn]

Am 02.08.12 23:14, schrieb Ryan Schmidt:
> On Aug 2, 2012, at 06:57, ciserlohn at macports.org wrote:
>
>> Revision: 96177
>>          https://trac.macports.org/changeset/96177
>> Author:   ciserlohn at macports.org
>> Date:     2012-08-02 04:57:24 -0700 (Thu, 02 Aug 2012)
>> Log Message:
>> -----------
>> jruby-devel (new port), jruby: development version of jruby; conflicts with jruby
>> Added: trunk/dports/lang/jruby-devel/Portfile
>> ===================================================================
>> --- trunk/dports/lang/jruby-devel/Portfile	                        (rev 0)
>> +++ trunk/dports/lang/jruby-devel/Portfile	2012-08-02 11:57:24 UTC (rev 96177)
> Ideally you should have "svn copy"d jruby to jruby-devel and then made changes. That way, the history of jruby-devel (as seen in commands like "svn log" and "svn blame") would have been intact.
ACK
>> @@ -0,0 +1,106 @@
>> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
> The jruby and jruby-devel Portfiles don't actually conform to this modeline. The modeline says indentations occur at multiples of 4 spaces, but the whitespace of the Portfiles has indentations occurring at multiples of 2 spaces. Either the Portfiles' modelines or their whitespace should be changed so that they agree with one another.
This was already the case when I took over the jruby port and I didn't
even notice. It's now fixed.
>> +# $Id: Portfile 92712 2012-05-04 15:03:18Z ciserlohn at macports.org $
> Don't forget to configure your svn autoprops so that svn:keywords and svn:eol-style are automatically set on new Portfiles that you commit.
>
> https://trac.macports.org/wiki/CommittersTipsAndTricks#SetsvnpropertiesautomaticallyonnewPortfiles
>
Oops. My development machine is configured this way but I made the
commit from another machine which was apparently not properly configured.
I'll try to be more thorough in the future.

Kind Regards,
Christoph