[97080] trunk/dports/devel/omniORB/Portfile

[Ryan Schmidt]

On Aug 27, 2012, at 00:33, stromnov at macports.org wrote:

> Revision: 97080
>          https://trac.macports.org/changeset/97080
> Author:   stromnov at macports.org
> Date:     2012-08-26 22:33:55 -0700 (Sun, 26 Aug 2012)
> Log Message:
> -----------
> omniORB: proper installation paths (see #35823)
> 
> Modified Paths:
> --------------
>    trunk/dports/devel/omniORB/Portfile
> 
> Modified: trunk/dports/devel/omniORB/Portfile
> ===================================================================
> --- trunk/dports/devel/omniORB/Portfile	2012-08-27 05:21:50 UTC (rev 97079)
> +++ trunk/dports/devel/omniORB/Portfile	2012-08-27 05:33:55 UTC (rev 97080)
> 


> +configure.args-delete --disable-dependency-tracking

--disable-dependency-tracking is not in configure.args. It is in configure.universal_args. But this only occurs in the universal variant, which you're turning off:

> -# Universal variant broken since 4.1.6
> +# The universal variant has been broken for several years (at least version 4.1.4)
> universal_variant   no

And then turning on again later?

> +# Need an empty universal variant defined to get the correct set of -arch arguments
> +variant universal {}

Note that you must define the universal variant *before* you start using [get_canonical_archflags]:

> +configure.args      CC="${configure.cc}" \
> +                    CXX="${configure.cxx}" \
> +                    CCFLAGS="[get_canonical_archflags cc]" \
> +                    EXTRA_GCC_CXXFLAGS="[get_canonical_archflags cc]" \
> +                    --with-omniORB-config="${prefix}/etc/omniORB.cfg" \

Shouldn't EXTRA_GCC_CXXFLAGS get [get_canonical_archflags cxx] instead? Not that there's any difference between the two today...


> post-patch {
> -    reinplace "s|,prefix=\'\$PYTHON_PREFIX\'||g" ${worksrcpath}/configure
> -    reinplace "s|,prefix=\'\$PYTHON_EXEC_PREFIX\'||g" ${worksrcpath}/configure
> +    reinplace "s|\\(\$(CXXLINKOPTIONS)\\)|\\1 [get_canonical_archflags cc]|g" \
> +        ${worksrcpath}/mk/beforeauto.mk.in

Shouldn't it be [get_canonical_archflags cxx] here as well?




> -if { ![variant_isset python24] && ![variant_isset python25] && ![variant_isset python26] && ![variant_isset python27]} {
> -    default_variants        +python27
> +if {![variant_isset python24] && ![variant_isset python25] && ![variant_isset python26] && ![variant_isset python27]} {
> +    default_variants        +python24

The default python variant should remain python27.