[100449] users/raimue/ports/sysutils/collectd

[Rainer Müller]

On 2012-12-12 18:25, Ryan Schmidt wrote:
>> Modified: users/raimue/ports/sysutils/collectd/Portfile
>> ===================================================================
>> --- users/raimue/ports/sysutils/collectd/Portfile	2012-12-12 16:57:53 UTC (rev 100448)
>> +++ users/raimue/ports/sysutils/collectd/Portfile	2012-12-12 16:58:33 UTC (rev 100449)
>> @@ -319,6 +319,14 @@
>>     configure.args-append --enable-email
>> }
>>
>> +variant tokyotyrant description {TokyoTyrant database statistics} {
>> +    configure.args-delete --disable-tokyotyrant
>> +    configure.args-append --enable-tokyotyrant
>> +
>> +    depends_lib-delete port:tokyotyrant
>> +    depends_lib-append port:tokyotyrant
>> +}
>> +
>> variant ntpd description {NTPd statistics} {
>>     configure.args-delete --disable-ntpd
>>     configure.args-append --enable-ntpd
>> @@ -406,6 +414,14 @@
>>     depends_lib-append port:curl port:libxml2
>> }
>>
>> +variant varnish description {Varnish cache statistics} {
>> +    configure.args-delete --disable-varnish
>> +    configure.args-append --enable-varnish
>> +
>> +    depends_lib-delete port:varnish
>> +    depends_lib-append port:varnish
>> +}
> 
> Something wrong... deleting and then appending the same dependency?

Hm, right. This is the code that was originally written by Clemens, so
probably he can clarify this. I guess it is written this way to avoid
adding a dependency twice.

Although there is a valid point: should we check for duplicates in base
when using depends_*-append? Are there other options we treat as a set
rather than a string or list?

Rainer