[100683] trunk/dports/gis

[Ryan Schmidt]

On Dec 20, 2012, at 05:35, vince at macports.org wrote:

> Revision: 100683
>          https://trac.macports.org/changeset/100683
> Author:   vince at macports.org
> Date:     2012-12-20 03:35:26 -0800 (Thu, 20 Dec 2012)
> Log Message:
> -----------
> Initial commit.
> 
> Added Paths:
> -----------
>    trunk/dports/gis/libpcl/
>    trunk/dports/gis/libpcl/Portfile


> +# PCL 1.6 does not compile with clang or macports-gcc-4.x
> +configure.compiler	llvm-gcc-4.2

You should use "compiler.blacklist" to blacklist compilers that don't work, instead of mandating a particular compiler:

compiler.blacklist clang

Especially, mandating llvm-gcc-4.2 will not work on versions of Xcode that do not provide llvm-gcc-4.2, such as Xcode 2.5.

Preferably, fix the port so that it compiles with clang. If you cannot, file a bug report with the developers, and put a link to that bug report in a comment in the portfile.

IMO there is no need to blacklist macports-gcc-anything since there is no supported configuration of MacPorts that would have a macports-gcc compiler as the default compiler.


> +configure.pre_args  -DCMAKE_INSTALL_PREFIX=${prefix}
> +configure.args      -DCMAKE_BUILD_TYPE=Release \
> +                    -DCMAKE_INSTALL_NAME_DIR=${prefix}/lib

You can remove these lines since the cmake portgroup already includes them.