[100789] trunk/dports/lang/tcl/Portfile

[Ryan Schmidt]

On Dec 24, 2012, at 12:38, g5pw at macports.org wrote:

> Revision: 100789
>          https://trac.macports.org/changeset/100789
> Author:   g5pw at macports.org
> Date:     2012-12-24 10:37:59 -0800 (Mon, 24 Dec 2012)
> Log Message:
> -----------
> lang/tcl:
>  fix threads variant, enable by default since threads are enabled by
>  default in 8.6
> 
> Modified Paths:
> --------------
>    trunk/dports/lang/tcl/Portfile
> 
> Modified: trunk/dports/lang/tcl/Portfile
> ===================================================================
> --- trunk/dports/lang/tcl/Portfile	2012-12-24 17:54:37 UTC (rev 100788)
> +++ trunk/dports/lang/tcl/Portfile	2012-12-24 18:37:59 UTC (rev 100789)
> @@ -4,6 +4,7 @@
> 
> name          tcl
> version       8.6.0
> +revision      1
> # Tk (x11/tk) port depends on this version
> categories    lang
> license       Tcl/Tk
> @@ -27,7 +28,8 @@
> distname        ${name}${version}-src
> worksrcdir      ${name}${version}/unix
> configure.args  --mandir=${prefix}/share/man \
> -                --disable-corefoundation
> +                --disable-corefoundation \
> +                --disable-threads
> configure.cppflags-delete  -I${prefix}/include
> configure.ldflags-delete   -L${prefix}/lib
> 
> @@ -44,6 +46,7 @@
> # dont enable threads by default as Tcl uses thread-local storage which makes
> # passing Tcl_Obj* around between threads fatal
> variant threads description {add multithreading support} {
> +    configure.args-delete --disable-threads
>     configure.args-append --enable-threads
> }
> 
> @@ -53,7 +56,7 @@
>         configure.args-delete --disable-corefoundation
>     }
>     # tk +quartz crashes at launch without CF support
> -    default_variants +corefoundation
> +    default_variants +corefoundation +threads
> }

This will set +threads as a default variant only on platform macosx. Shouldn't +threads be a default variant on all platforms?


Index: Portfile
===================================================================
--- Portfile	(revision 100793)
+++ Portfile	(working copy)
@@ -49,6 +49,7 @@
     configure.args-delete --disable-threads
     configure.args-append --enable-threads
 }
+default_variants +threads
 
 platform macosx {
     # CF is not fork()-safe and software e.g. using tk and fork() will crash
@@ -56,7 +57,7 @@
         configure.args-delete --disable-corefoundation
     }
     # tk +quartz crashes at launch without CF support
-    default_variants +corefoundation +threads
+    default_variants +corefoundation
 }
 
 variant memdebug description {enable memory debugging support} {