[89669] trunk/dports/_resources/port1.0/group/github-1.0.tcl

[Ryan Schmidt]

On Feb 6, 2012, at 07:20, and.damore at macports.org wrote:

> Revision: 89669
>          http://trac.macports.org/changeset/89669
> Author:   and.damore at macports.org
> Date:     2012-02-06 05:20:28 -0800 (Mon, 06 Feb 2012)
> Log Message:
> -----------
> github portgroup: no need to append version to tag in master_sites

Yes, there is. Consider port jake, whose github.setup line is:

github.setup        mde jake 0.2.15 v


Before this change, the port would download from this URL:

https://github.com/mde/jake/tarball/v0.2.15/jake-0.2.15.tar.gz

This is correct. github ignores the distname (in this case "jake-0.2.15.tar.gz"); we could put anything there at all. The only way github knows what file we want is if we specify the entire correct tagname (in this case "v0.2.15").


Now after the change, the download URL is as follows, which is 404 not found:

https://github.com/mde/jake/tarball/v/jake-0.2.15.tar.gz


This change should be reverted.


> Modified Paths:
> --------------
>    trunk/dports/_resources/port1.0/group/github-1.0.tcl
> 
> Modified: trunk/dports/_resources/port1.0/group/github-1.0.tcl
> ===================================================================
> --- trunk/dports/_resources/port1.0/group/github-1.0.tcl	2012-02-06 13:20:01 UTC (rev 89668)
> +++ trunk/dports/_resources/port1.0/group/github-1.0.tcl	2012-02-06 13:20:28 UTC (rev 89669)
> @@ -41,7 +41,7 @@
> 
> default github.homepage {https://github.com/${github.author}/${github.project}}
> default github.raw {https://raw.github.com/${github.author}/${github.project}}
> -default github.master_sites {${github.homepage}/tarball/[join ${github.tag_prefix} ""]${github.version}}
> +default github.master_sites {${github.homepage}/tarball/[join ${github.tag_prefix} ""]}
> 
> proc github.setup {gh_author gh_project gh_version {gh_tag_prefix ""}} {
>     global github.author github.project github.version github.tag_prefix github.homepage github.master_sites