[90280] trunk/dports/graphics/wxWidgets/Portfile

Wahlstedt Jyrki jwa at macports.org
Wed Feb 29 09:07:15 PST 2012


On 29.2.2012, at 17.53, Ryan Schmidt wrote:

> Why add a flag, then immediately remove the flag (for 4.3)? Why not only add the flag if it's needed?
> 
> More importantly, you should be using [vercmp] to test whether the Xcode version is 4.3 *or greater*; what you committed above will fail as soon as a newer version of Xcode is released.
> 
> Also, please don't hardcode /Applications/Xcode.app/Contents/Developer; isn't that what ${developer_dir} should be with Xcode 4.3?

Hi,
I'll do those in the next refinement, thanks again…

!
! Jyrki Wahlstedt
!	http://www.wahlstedt.fi/jyrki/
!
! Our life is no dream; but it ought to become one and perhaps will.
! PGP key ID: 0x139CC386 fingerprint: F355 B46F 026C B8C1 89C0  A780 6366 EFD9 139C C386





More information about the macports-dev mailing list