[89294] users/pixilla/dports

[Ryan Schmidt]

On Jan 23, 2012, at 16:28, pixilla at macports.org wrote:

> Revision: 89294
>          http://trac.macports.org/changeset/89294
> Author:   pixilla at macports.org
> Date:     2012-01-23 14:28:04 -0800 (Mon, 23 Jan 2012)
> Log Message:
> -----------
> pixilla/dports:
> - Add graphics/librsvg-minimal.
> 
> Added Paths:
> -----------
>    users/pixilla/dports/graphics/
>    users/pixilla/dports/graphics/librsvg-minimal/
>    users/pixilla/dports/graphics/librsvg-minimal/Portfile
> 
> Added: users/pixilla/dports/graphics/librsvg-minimal/Portfile
> ===================================================================
> --- users/pixilla/dports/graphics/librsvg-minimal/Portfile	                        (rev 0)
> +++ users/pixilla/dports/graphics/librsvg-minimal/Portfile	2012-01-23 22:28:04 UTC (rev 89294)
> @@ -0,0 +1,70 @@
> +# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:filetype=tcl:et:sw=4:ts=4:sts=4
> +# $Id$
> +
> +PortSystem          1.0
> +PortGroup           archcheck 1.0
> +
> +name                librsvg-minimal
> +conflicts           librsvg

Could librsvg-minimal be a subport of librsvg, instead of its own separate port?

> +distname            ${name_package}-${version}

If you keep it as a separate port, please set "dist_subdir ${name_package}" so that the distfile isn't unnecessarily downloaded/mirrored a second time.

> +configure.args      --prefix=${prefix} \

--prefix=${prefix} should not appear in configure.args since it's already in configure.pre_args.

> +post-activate {
> +    ui_debug "Updating gdk-pixbuf.loaders..."
> +    system "${prefix}/bin/gdk-pixbuf-query-loaders --update-cache"
> +}

Since the cache is updated after activation, does it also need to be updated after de-activation? This question applies to librsvg as well.